Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mark Node.js 8 End-of-Life in CHANGELOG #31152

Closed
wants to merge 1 commit into from
Closed

doc: mark Node.js 8 End-of-Life in CHANGELOG #31152

wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

(I didn't spot another PR open for this)

Checklist

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 2, 2020
@gireeshpunathil
Copy link
Member

on a slightly related note, what do we do with outstanding backport-requested-v8.x PRs and outstanding v8.x issues ?

@BethGriggs
Copy link
Member Author

@gireeshpunathil - there is no longer a backport-requested-v6.x label, from that I assume that we would delete the backport-requested-v8.x label.

I don't know what we've done historically with issues - but closing any v8.x specific issues with a comment saying Node.js 8 is now End-of-Life and we do not plan to fix the issue (and adding the wontfix label) seems reasonable?

richardlau
richardlau approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for a separate PR but it’s probably time to remove the old entries from the bottom of this file (the ones that redirect to the other CHANGELOG files).

@BridgeAR
Copy link
Member

BridgeAR commented Jan 2, 2020

I just went through the open v8.x issues and backports and closed them in case they only applied to v8.x and otherwise updated the labels.

I also removed all v8.x related labels as they are not relevant anymore.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 2, 2020
MylesBorins
MylesBorins approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

Fasttrack?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 3, 2020
@Trott
Copy link
Member

Trott commented Jan 4, 2020

Landed in d845915

@Trott Trott closed this Jan 4, 2020
Trott pushed a commit that referenced this pull request Jan 4, 2020
@BethGriggs @Trott
doc: mark Node.js 8 End-of-Life in CHANGELOG
d845915 
PR-URL: #31152
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@BethGriggs BethGriggs deleted the 8-eol branch January 4, 2020 19:40
@BethGriggs BethGriggs mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github sam-github approved these changes

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.